[
https://issues.apache.org/jira/browse/FLUME-1099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13246169#comment-13246169
]
[email protected] commented on FLUME-1099:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4635/#review6676
-----------------------------------------------------------
Ship it!
- Brock
On 2012-04-04 06:37:05, Will McQueen wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4635/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-04-04 06:37:05)
bq.
bq.
bq. Review request for Flume.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Looks like copy-paste error with prop keys
bq.
bq.
bq. This addresses bug FLUME-1099.
bq. https://issues.apache.org/jira/browse/FLUME-1099
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
flume-ng-channels/flume-recoverable-memory-channel/src/main/java/org/apache/flume/channel/recoverable/memory/RecoverableMemoryChannel.java
2d08b68
bq.
bq. Diff: https://reviews.apache.org/r/4635/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Will
bq.
bq.
> copy-paste issue with RecoverableMemoryChannel
> ----------------------------------------------
>
> Key: FLUME-1099
> URL: https://issues.apache.org/jira/browse/FLUME-1099
> Project: Flume
> Issue Type: Bug
> Components: Channel
> Affects Versions: v1.2.0
> Environment: [CentOS 6.2 64-bit]
> commit 0a6ead7104d7bc04903c2604c60125f34ef8e00f
> trunk
> Reporter: Will McQueen
> Assignee: Will McQueen
> Fix For: v1.2.0
>
> Attachments: copypasteissue.patch
>
>
> Looks like RecoverableMemoryChannel has a copy-paste error
> Patch att'd
> \- long maxLogsSize = context.getLong(WAL_ROLL_SIZE,
> WAL.DEFAULT_MAX_LOGS_SIZE);
> \- long minRententionPeriod = context.getLong(WAL_ROLL_SIZE,
> WAL.DEFAULT_MIN_LOG_RENTENTION_PERIOD);
> \- long workerInterval = context.getLong(WAL_ROLL_SIZE,
> WAL.DEFAULT_WORKER_INTERVAL);
> + long maxLogsSize = context.getLong(WAL_MAX_LOGS_SIZE,
> WAL.DEFAULT_MAX_LOGS_SIZE);
> + long minRententionPeriod = context.getLong(WAL_MIN_RENTENTION_PERIOD,
> WAL.DEFAULT_MIN_LOG_RENTENTION_PERIOD);
> + long workerInterval = context.getLong(WAL_WORKER_INTERVAL,
> WAL.DEFAULT_WORKER_INTERVAL);
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
