----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4638/#review6699 -----------------------------------------------------------
Ship it! lgtm - Prasad On 2012-04-04 18:51:44, Mike Percy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4638/ > ----------------------------------------------------------- > > (Updated 2012-04-04 18:51:44) > > > Review request for Flume. > > > Summary > ------- > > Fix for rollInterval. Also added unit tests for the BucketWriter. > > > This addresses bug FLUME-1102. > https://issues.apache.org/jira/browse/FLUME-1102 > > > Diffs > ----- > > > flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/BucketWriter.java > 3d00e64 > > flume-ng-sinks/flume-hdfs-sink/src/test/java/org/apache/flume/sink/hdfs/TestBucketWriter.java > PRE-CREATION > flume-ng-sinks/flume-hdfs-sink/src/test/resources/log4j.properties > PRE-CREATION > > flume-ng-sinks/flume-hdfs-sink/src/test/java/org/apache/flume/sink/hdfs/MockHDFSWriter.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/4638/diff > > > Testing > ------- > > Unit tests pass. > > > Thanks, > > Mike > >
