[
https://issues.apache.org/jira/browse/FLUME-1089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13246973#comment-13246973
]
[email protected] commented on FLUME-1089:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4655/
-----------------------------------------------------------
Review request for Flume.
Summary
-------
Allowing the calling of transaction.close() at any point of time.
This addresses bug FLUME-1089.
https://issues.apache.org/jira/browse/FLUME-1089
Diffs
-----
flume-ng-core/src/main/java/org/apache/flume/channel/BasicTransactionSemantics.java
403cbca
flume-ng-core/src/test/java/org/apache/flume/channel/TestBasicChannelSemantics.java
80020fc
flume-ng-core/src/test/java/org/apache/flume/channel/TestMemoryChannelTransaction.java
bc81f26
Diff: https://reviews.apache.org/r/4655/diff
Testing
-------
Unit tests pass.
Thanks,
Brock
> Transaction.close should be safe to call at any point
> -----------------------------------------------------
>
> Key: FLUME-1089
> URL: https://issues.apache.org/jira/browse/FLUME-1089
> Project: Flume
> Issue Type: Improvement
> Reporter: Brock Noland
> Assignee: Brock Noland
> Attachments: FLUME-1089-0.patch
>
>
> We are struggling with error handling in regards to transactions. The general
> consensus is that it should be safe to call close on a transaction at any
> point.
> Discussion on flume-dev here:
> http://mail-archives.apache.org/mod_mbox/incubator-flume-dev/201203.mbox/%3CCAFukC=5X99U=aOZ5qMR_OoF=pz9f7yhl6ofkyzu08ut4or0...@mail.gmail.com%3E
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
