[
https://issues.apache.org/jira/browse/FLUME-1001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13246977#comment-13246977
]
jirapos...@reviews.apache.org commented on FLUME-1001:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4152/#review6704
-----------------------------------------------------------
Ship it!
looks good to me, just one nit. After you address to the nit please attache the
patch to the JIRA.
flume-ng-core/src/main/java/org/apache/flume/sink/SinkProcessorFactory.java
<https://reviews.apache.org/r/4152/#comment14508>
INFO is more appropriate, people freak out when they see WARN.
- Brock
On 2012-03-05 03:25:20, Juhani Connolly wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4152/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-03-05 03:25:20)
bq.
bq.
bq. Review request for Flume.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Made custom processors possible in the same way as sink and source: the
type can represent a classname or a shorthand name from the typedef.
bq.
bq.
bq. This addresses bug FLUME-1001.
bq. https://issues.apache.org/jira/browse/FLUME-1001
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
flume-ng-core/src/test/java/org/apache/flume/sink/TestSinkProcessorFactory.java
PRE-CREATION
bq. flume-ng-core/src/main/java/org/apache/flume/SinkProcessorType.java
be1891b
bq.
flume-ng-core/src/main/java/org/apache/flume/sink/SinkProcessorFactory.java
10f9f4e
bq.
bq. Diff: https://reviews.apache.org/r/4152/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Existing tests pass, except I'm having an issue with TestNetcatSource
which seems to be totally unrelated... It turns up on flume-728 head too,
probably something in my environment
bq.
bq. Added a new test to verify that processors created by shorthand name and
by full class create the same class, verifying that creation by classname also
works
bq.
bq.
bq. Thanks,
bq.
bq. Juhani
bq.
bq.
> Support custom processors
> -------------------------
>
> Key: FLUME-1001
> URL: https://issues.apache.org/jira/browse/FLUME-1001
> Project: Flume
> Issue Type: Improvement
> Components: Sinks+Sources
> Affects Versions: v1.1.0
> Environment: RHEL 6.2 64-bit
> Reporter: Will McQueen
> Assignee: Juhani Connolly
> Fix For: v1.2.0
>
> Attachments: FLUME-1001.2.patch
>
>
> Currently there doesn't seem to be a way for a user to specify a custom
> processor... for example, a replicating processor that replicates a channel's
> output to all sinks. If this is implemented in a way to how custom sources
> and sinks are implemented, then we'd need a SinkProcessor.OTHER type, as a
> start.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
