----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4667/#review6736 -----------------------------------------------------------
Ship it! lgtm. just a minor comment about the log message. /trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/impl/JdbcChannelProviderImpl.java <https://reviews.apache.org/r/4667/#comment14686> It would be better to make it an info message than warning. - Prasad On 2012-04-06 04:40:53, Arvind Prabhakar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4667/ > ----------------------------------------------------------- > > (Updated 2012-04-06 04:40:53) > > > Review request for Flume. > > > Summary > ------- > > Created a configuration option which controls the creation of foreign key > constraints for the jdbc channel. The value of this option is true by > default, which implies that the FK constraints will be created. To disable > these constraints, the user must explicitly turn it off via configuration. > > > This addresses bug FLUME-1105. > https://issues.apache.org/jira/browse/FLUME-1105 > > > Diffs > ----- > > > /trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/ConfigurationConstants.java > 1310152 > > /trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/impl/DerbySchemaHandler.java > 1310152 > > /trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/impl/JdbcChannelProviderImpl.java > 1310152 > > /trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/impl/MySQLSchemaHandler.java > 1310152 > > /trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/impl/SchemaHandler.java > 1310152 > > /trunk/flume-ng-channels/flume-jdbc-channel/src/test/java/org/apache/flume/channel/jdbc/TestDerbySchemaHandlerQueries.java > 1310152 > > Diff: https://reviews.apache.org/r/4667/diff > > > Testing > ------- > > Ran full tests. Also manually verified that the fk constraints could be > created or not via the configuration option. > > > Thanks, > > Arvind > >
