----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4676/#review6765 -----------------------------------------------------------
Ship it! +1 Thanks for the patch Hari. - Arvind On 2012-04-07 02:33:01, Hari Shreedharan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4676/ > ----------------------------------------------------------- > > (Updated 2012-04-07 02:33:01) > > > Review request for Flume. > > > Summary > ------- > > Refactoring Syslog sources, to fix a bunch of data loss problems encountered. > > > This addresses bug FLUME-1109. > https://issues.apache.org/jira/browse/FLUME-1109 > > > Diffs > ----- > > flume-ng-core/src/main/java/org/apache/flume/source/SyslogTcpSource.java > d78d27f > flume-ng-core/src/main/java/org/apache/flume/source/SyslogUDPSource.java > 34818f0 > flume-ng-core/src/main/java/org/apache/flume/source/SyslogUtils.java > ceb9ff1 > > flume-ng-core/src/test/java/org/apache/flume/source/TestSyslogUdpSource.java > d1db49d > flume-ng-core/src/test/java/org/apache/flume/source/TestSyslogUtils.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/4676/diff > > > Testing > ------- > > Did a bunch of functional tests. Also added unit tests for SylogUtils. > > > Thanks, > > Hari > >
