[
https://issues.apache.org/jira/browse/FLUME-1109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13249155#comment-13249155
]
[email protected] commented on FLUME-1109:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4676/#review6765
-----------------------------------------------------------
Ship it!
+1
Thanks for the patch Hari.
- Arvind
On 2012-04-07 02:33:01, Hari Shreedharan wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4676/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-04-07 02:33:01)
bq.
bq.
bq. Review request for Flume.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Refactoring Syslog sources, to fix a bunch of data loss problems
encountered.
bq.
bq.
bq. This addresses bug FLUME-1109.
bq. https://issues.apache.org/jira/browse/FLUME-1109
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. flume-ng-core/src/main/java/org/apache/flume/source/SyslogTcpSource.java
d78d27f
bq. flume-ng-core/src/main/java/org/apache/flume/source/SyslogUDPSource.java
34818f0
bq. flume-ng-core/src/main/java/org/apache/flume/source/SyslogUtils.java
ceb9ff1
bq.
flume-ng-core/src/test/java/org/apache/flume/source/TestSyslogUdpSource.java
d1db49d
bq. flume-ng-core/src/test/java/org/apache/flume/source/TestSyslogUtils.java
PRE-CREATION
bq.
bq. Diff: https://reviews.apache.org/r/4676/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Did a bunch of functional tests. Also added unit tests for SylogUtils.
bq.
bq.
bq. Thanks,
bq.
bq. Hari
bq.
bq.
> Syslog sources need to be refactored
> ------------------------------------
>
> Key: FLUME-1109
> URL: https://issues.apache.org/jira/browse/FLUME-1109
> Project: Flume
> Issue Type: Bug
> Components: Sinks+Sources
> Affects Versions: v1.1.0
> Reporter: Hari Shreedharan
> Assignee: Hari Shreedharan
> Attachments: FLUME-1109-1.patch
>
>
> There is data loss in the syslog source.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
