[
https://issues.apache.org/jira/browse/FLUME-1108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13249240#comment-13249240
]
[email protected] commented on FLUME-1108:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4672/#review6770
-----------------------------------------------------------
Ship it!
LGTM!
Yes, I think it would be useful especially in testing scenario. This can be
considered the degenerate case, and doesn't affect existing functionality. It's
consistent with semantics for other sources/sinks where "0" value is specified.
Saves user from needing to enter a high value for rolloverInterval when running
multi-day endurance tests.
- Will
On 2012-04-06 19:29:44, Hari Shreedharan wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4672/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-04-06 19:29:44)
bq.
bq.
bq. Review request for Flume.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. If rollInterval is set to 0, RollingFileSink does not roll file.
bq.
bq.
bq. This addresses bug FLUME-1108.
bq. https://issues.apache.org/jira/browse/FLUME-1108
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. flume-ng-core/src/main/java/org/apache/flume/sink/RollingFileSink.java
7f1d3b3
bq.
flume-ng-core/src/test/java/org/apache/flume/sink/TestRollingFileSink.java
7e26e2a
bq.
bq. Diff: https://reviews.apache.org/r/4672/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Added unit test.
bq.
bq.
bq. Thanks,
bq.
bq. Hari
bq.
bq.
> FILE_ROLL sink doesn't accept value 0 for unlimited wait time before rolling
> file
> ---------------------------------------------------------------------------------
>
> Key: FLUME-1108
> URL: https://issues.apache.org/jira/browse/FLUME-1108
> Project: Flume
> Issue Type: Bug
> Components: Sinks+Sources
> Affects Versions: v1.2.0
> Environment: [CentOS 5.7 64-bit]
> Reporter: Will McQueen
> Assignee: Hari Shreedharan
> Fix For: v1.2.0
>
> Attachments: FLUME-1108-1.patch
>
>
> Using FILE_ROLL sink and the following props for it:
> sink.directory=/home/will/logs
> sink.rollInterval=0
> ...the logical expectation should should be that the file never gets rolled
> -- all output should go to single file.
> 2012-04-06 10:50:33,272 ERROR lifecycle.LifecycleSupervisor: Unable to start
> SinkRunner: { policy:org.apache.flume.sink.DefaultSinkProcessor@d6089a5
> counterGroup:{ name:null counters:{} } } - Exception follows.
> java.lang.IllegalArgumentException
> at
> java.util.concurrent.ScheduledThreadPoolExecutor.scheduleAtFixedRate(ScheduledThreadPoolExecutor.java:420)
> at
> org.apache.flume.sink.RollingFileSink.start(RollingFileSink.java:104)
> at
> org.apache.flume.sink.DefaultSinkProcessor.start(DefaultSinkProcessor.java:43)
> at org.apache.flume.SinkRunner.start(SinkRunner.java:79)
> at
> org.apache.flume.lifecycle.LifecycleSupervisor$MonitorRunnable.run(LifecycleSupervisor.java:221)
> at
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:441)
> at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:303)
> at java.util.concurrent.FutureTask.run(FutureTask.java:138)
> at
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:98)
> at
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:206)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
> at java.lang.Thread.run(Thread.java:662)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
