-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4663/#review6772
-----------------------------------------------------------



flume-ng-core/src/main/java/org/apache/flume/source/SourceType.java
<https://reviews.apache.org/r/4663/#comment14930>

    SYSLOGTCP => SYSLOG_TCP
    (to match current convention of underscore-separated words, like with 
FILE_ROLL)



flume-ng-core/src/main/java/org/apache/flume/source/SourceType.java
<https://reviews.apache.org/r/4663/#comment14931>

    SYSLOGUDP => SYSLOG_UDP
    (to match current convention of underscore-separated words, like with 
FILE_ROLL)


- Will


On 2012-04-06 01:07:45, Hari Shreedharan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4663/
> -----------------------------------------------------------
> 
> (Updated 2012-04-06 01:07:45)
> 
> 
> Review request for Flume.
> 
> 
> Summary
> -------
> 
> Adding SyslogTcpSource and SyslogUDPSource to the enum.
> 
> 
> This addresses bug FLUME-1017.
>     https://issues.apache.org/jira/browse/FLUME-1017
> 
> 
> Diffs
> -----
> 
>   flume-ng-core/src/main/java/org/apache/flume/source/SourceType.java 9082470 
> 
> Diff: https://reviews.apache.org/r/4663/diff
> 
> 
> Testing
> -------
> 
> Builds fine, current unit tests are ok.
> 
> 
> Thanks,
> 
> Hari
> 
>

Reply via email to