[
https://issues.apache.org/jira/browse/FLUME-1107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13249322#comment-13249322
]
[email protected] commented on FLUME-1107:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4677/
-----------------------------------------------------------
(Updated 2012-04-07 20:01:51.619038)
Review request for Flume.
Changes
-------
Thanks for the review Will. I have incorporated your suggestions.
Summary
-------
Modified the implementation to deprecate the old form of configuration keys for
JDBC channel. The new form takes precedence if both types are present.
This addresses bug FLUME-1107.
https://issues.apache.org/jira/browse/FLUME-1107
Diffs (updated)
-----
/trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/ConfigurationConstants.java
1310683
/trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/impl/JdbcChannelProviderImpl.java
1310683
/trunk/flume-ng-channels/flume-jdbc-channel/src/test/java/org/apache/flume/channel/jdbc/TestJdbcChannelProvider.java
1310683
Diff: https://reviews.apache.org/r/4677/diff
Testing
-------
Ran JDBC channel unit tests with the deprecated old form of configuration keys.
Updated the tests to use the new form and tested as well.
Thanks,
Arvind
> Configuration keys for JDBC channel contain redundant prefix.
> -------------------------------------------------------------
>
> Key: FLUME-1107
> URL: https://issues.apache.org/jira/browse/FLUME-1107
> Project: Flume
> Issue Type: Sub-task
> Components: Channel
> Reporter: Arvind Prabhakar
> Assignee: Arvind Prabhakar
> Fix For: v1.2.0
>
> Attachments: FLUME-1107-1.patch
>
>
> The configuration keys for JDBC channel currently require a prefix which
> serves no purpose as the configuration is already namespace isolated within
> the configuration system.
> For example, to set the capacity of the channel named "jdbcchannel", the
> configuration setting will look like:
> {code}
> agent.channels.jdbcchannel.org.apache.flume.channel.jdbc.maximum.capacity =
> 1000
> {code}
> It is preferable that the setting be of the short form like the following:
> {code}
> agent.channels.jdbcchannel.maximum.capacity = 1000
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
