> On 2012-04-07 12:57:18, Will McQueen wrote: > > flume-ng-core/src/main/java/org/apache/flume/source/AvroSource.java, line > > 125 > > <https://reviews.apache.org/r/4669/diff/2/?file=100629#file100629line125> > > > > Recommend this warning string: > > AVRO source\'s \"threads\" prop must specify integer value. > > > > (here we're using the name of the type instead of the class name)
modified - Juhani ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4669/#review6771 ----------------------------------------------------------- On 2012-04-09 10:07:06, Juhani Connolly wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4669/ > ----------------------------------------------------------- > > (Updated 2012-04-09 10:07:06) > > > Review request for Flume. > > > Summary > ------- > > A rudimentary fix allowing setting a thread limit to the netty server used > for avro ipc. > > A more involved solution would be to implement a custom thread pool but I > don't think that is entirely necessary > > > This addresses bug FLUME-1011. > https://issues.apache.org/jira/browse/FLUME-1011 > > > Diffs > ----- > > flume-ng-core/src/test/java/org/apache/flume/source/TestAvroSource.java > c5c3f2f > flume-ng-core/src/main/java/org/apache/flume/source/AvroSource.java 903889d > > Diff: https://reviews.apache.org/r/4669/diff > > > Testing > ------- > > Added the new setting into one of the tests to make sure it is exercised > > Tests pass individually, I'm still having issues with running several of the > RPC related tests from mvn, but this was the case before adding this code. > > > Thanks, > > Juhani > >
