----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4708/#review6901 -----------------------------------------------------------
I think we should log a separate jira to address cleanly integrating the Avro serializer with HDFS sink. Got a few minor comments, mainly calling flush/sync of the serializer and the stream is bit inconsistent. Rest look fine to me. flume-ng-core/src/main/java/org/apache/flume/sink/RollingFileSink.java <https://reviews.apache.org/r/4708/#comment15339> Do we need another outputStream flush after seriallizer.flush() ? flume-ng-core/src/main/java/org/apache/flume/sink/RollingFileSink.java <https://reviews.apache.org/r/4708/#comment15340> should it call serializer flush and beforeClose here ? - Prasad On 2012-04-12 13:06:04, Mike Percy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4708/ > ----------------------------------------------------------- > > (Updated 2012-04-12 13:06:04) > > > Review request for Flume. > > > Summary > ------- > > Patch with support for Avro Container File format. > > > This addresses bug FLUME-1117. > https://issues.apache.org/jira/browse/FLUME-1117 > > > Diffs > ----- > > flume-ng-core/pom.xml 37fb112 > > flume-ng-core/src/main/java/org/apache/flume/formatter/output/EventFormatter.java > c8b953d > > flume-ng-core/src/main/java/org/apache/flume/formatter/output/TextDelimitedOutputFormatter.java > a12afd3 > > flume-ng-core/src/main/java/org/apache/flume/serialization/AbstractAvroEventSerializer.java > PRE-CREATION > > flume-ng-core/src/main/java/org/apache/flume/serialization/BodyTextEventSerializer.java > PRE-CREATION > > flume-ng-core/src/main/java/org/apache/flume/serialization/EventSerializer.java > PRE-CREATION > > flume-ng-core/src/main/java/org/apache/flume/serialization/EventSerializerFactory.java > PRE-CREATION > > flume-ng-core/src/main/java/org/apache/flume/serialization/EventSerializerType.java > PRE-CREATION > > flume-ng-core/src/main/java/org/apache/flume/serialization/FlumeEventAvroEventSerializer.java > PRE-CREATION > flume-ng-core/src/main/java/org/apache/flume/sink/RollingFileSink.java > a2f4f66 > > flume-ng-core/src/test/java/org/apache/flume/serialization/SyslogAvroEventSerializer.java > PRE-CREATION > > flume-ng-core/src/test/java/org/apache/flume/serialization/TestBodyTextEventSerializer.java > PRE-CREATION > > flume-ng-core/src/test/java/org/apache/flume/serialization/TestFlumeEventAvroEventSerializer.java > PRE-CREATION > > flume-ng-core/src/test/java/org/apache/flume/serialization/TestSyslogAvroEventSerializer.java > PRE-CREATION > flume-ng-core/src/test/resources/syslog_event.avsc PRE-CREATION > > flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/BucketWriter.java > fdad75b > > flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/HDFSCompressedDataStream.java > c8e1df9 > > flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/HDFSDataStream.java > 39a4456 > > flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/HDFSEventSink.java > 9f28d82 > > flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/HDFSSequenceFile.java > 49a62df > > flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/HDFSWriter.java > 2e5470e > > flume-ng-sinks/flume-hdfs-sink/src/test/java/org/apache/flume/sink/hdfs/MockHDFSWriter.java > 73d3284 > > flume-ng-sinks/flume-hdfs-sink/src/test/java/org/apache/flume/sink/hdfs/TestBucketWriter.java > fb61092 > > flume-ng-sinks/flume-hdfs-sink/src/test/java/org/apache/flume/sink/hdfs/TestHDFSEventSink.java > 5a6ad47 > pom.xml 3a9bc42 > > Diff: https://reviews.apache.org/r/4708/diff > > > Testing > ------- > > Unit tests pass. New unit tests added for new functionality. > > > Thanks, > > Mike > >
