[ 
https://issues.apache.org/jira/browse/FLUME-1121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13253680#comment-13253680
 ] 

Hari Shreedharan commented on FLUME-1121:
-----------------------------------------

Apologies. I didn't look at your patch closely enough. Seems like you handle 
the above case, since you repopulate the memory channel before accepting more 
puts. 

But I am not sure if the reconfiguration case is handled correctly.

I can have this case right:
Capacity = 100.No sink, only one source.

Write 11 events to channel, commit and then fail. - Capacity not exceeded.

Reconfigure channel to 10 events. Now, the current code only logs error, but 
you'd still try to load all 11 to the memory channel. 

Otherwise, I think these changes look good.
                
> Recoverable Memory Channel cannot recover data 
> -----------------------------------------------
>
>                 Key: FLUME-1121
>                 URL: https://issues.apache.org/jira/browse/FLUME-1121
>             Project: Flume
>          Issue Type: Bug
>          Components: Sinks+Sources
>    Affects Versions: v1.2.0
>            Reporter: Hari Shreedharan
>
> Run an agent with a source, like seq with a recoverable memory channel and no 
> sink. kill the process with ctrl-C. Run an agent now with no source, but 
> logger sink and the same recoverable memory channel. I expected the events 
> generated by the source earlier should be written to the sink, but no events 
> with picked up. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to