> On 2012-04-17 14:34:44, Brock Noland wrote: > > flume-ng-core/src/main/java/org/apache/flume/lifecycle/LifecycleSupervisor.java, > > line 83 > > <https://reviews.apache.org/r/4753/diff/2/?file=102361#file102361line83> > > > > Should componentStartService be shutdown?
It isn't really required, because each of the components are shutdown in the lines that immediately follow. But I have submitted an update, with a shutdown call. - Hari ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4753/#review6979 ----------------------------------------------------------- On 2012-04-17 15:06:58, Hari Shreedharan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4753/ > ----------------------------------------------------------- > > (Updated 2012-04-17 15:06:58) > > > Review request for Flume. > > > Summary > ------- > > All components are started by the same executor, which is different from the > executor service that checks the status of the components. > > > This addresses bug FLUME-1124. > https://issues.apache.org/jira/browse/FLUME-1124 > > > Diffs > ----- > > > flume-ng-core/src/main/java/org/apache/flume/lifecycle/LifecycleSupervisor.java > a7407e6 > > Diff: https://reviews.apache.org/r/4753/diff > > > Testing > ------- > > > Thanks, > > Hari > >
