[
https://issues.apache.org/jira/browse/FLUME-1124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13255627#comment-13255627
]
[email protected] commented on FLUME-1124:
------------------------------------------------------
bq. On 2012-04-17 14:34:44, Brock Noland wrote:
bq. >
flume-ng-core/src/main/java/org/apache/flume/lifecycle/LifecycleSupervisor.java,
line 83
bq. > <https://reviews.apache.org/r/4753/diff/2/?file=102361#file102361line83>
bq. >
bq. > Should componentStartService be shutdown?
It isn't really required, because each of the components are shutdown in the
lines that immediately follow. But I have submitted an update, with a shutdown
call.
- Hari
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4753/#review6979
-----------------------------------------------------------
On 2012-04-17 15:06:58, Hari Shreedharan wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4753/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-04-17 15:06:58)
bq.
bq.
bq. Review request for Flume.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. All components are started by the same executor, which is different from
the executor service that checks the status of the components.
bq.
bq.
bq. This addresses bug FLUME-1124.
bq. https://issues.apache.org/jira/browse/FLUME-1124
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
flume-ng-core/src/main/java/org/apache/flume/lifecycle/LifecycleSupervisor.java
a7407e6
bq.
bq. Diff: https://reviews.apache.org/r/4753/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Hari
bq.
bq.
> Lifecycle supervisor can cause thread contention, sometimes causing
> components to not startup.
> ----------------------------------------------------------------------------------------------
>
> Key: FLUME-1124
> URL: https://issues.apache.org/jira/browse/FLUME-1124
> Project: Flume
> Issue Type: Bug
> Components: Sinks+Sources
> Affects Versions: v1.1.0
> Reporter: Hari Shreedharan
> Assignee: Hari Shreedharan
> Fix For: v1.2.0
>
> Attachments: FLUME-1124-1.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
