[
https://issues.apache.org/jira/browse/FLUME-1125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13255981#comment-13255981
]
[email protected] commented on FLUME-1125:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4759/#review6992
-----------------------------------------------------------
Ship it!
- Brock
On 2012-04-17 21:29:29, Mike Percy wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4759/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-04-17 21:29:29)
bq.
bq.
bq. Review request for Flume.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. We shouldn't allow the flume-env.sh variables to override command-line
parameters. This patch fixes that issue.
bq. This also adds support for a --dryrun parameter in order to test the
variations and cleans up the flume-env.sh.template file a little bit.
bq. The following vars are longer "clobberable" by flume-env.sh:
FLUME_CLASSPATH, JAVA_OPTS
bq.
bq.
bq. This addresses bug FLUME-1125.
bq. https://issues.apache.org/jira/browse/FLUME-1125
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. bin/flume-ng 145db32
bq. conf/flume-env.sh.template 0388ef9
bq.
bq. Diff: https://reviews.apache.org/r/4759/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Manually tested various combinations.
bq.
bq.
bq. Thanks,
bq.
bq. Mike
bq.
bq.
> flume-ng script allows flume-env.sh to clobber some command-line arguments
> --------------------------------------------------------------------------
>
> Key: FLUME-1125
> URL: https://issues.apache.org/jira/browse/FLUME-1125
> Project: Flume
> Issue Type: Bug
> Affects Versions: v1.1.0
> Reporter: Mike Percy
> Assignee: Mike Percy
> Fix For: v1.2.0
>
>
> Certain command-line arguments such as --classpath and -D* can be clobbered
> by specifying them as FLUME_CLASSPATH and JAVA_OPTS in flume-env.sh
> These command-line params should append to the values specified in the
> flume-env.sh script, if any.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
