[ 
https://issues.apache.org/jira/browse/FLUME-1130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13257201#comment-13257201
 ] 

[email protected] commented on FLUME-1130:
------------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4795/
-----------------------------------------------------------

(Updated 2012-04-19 04:00:02.087300)


Review request for Flume.


Changes
-------

Since the first patch has already been committed, the 2nd patch applies on top 
of the first one.

We need to allow scripts to define FLUME_HOME as an environment variable (even 
though environment variables are invisible and hard to debug) in order to 
support init scripts easily. This is one case where avoiding env vars and 
requiring everything to be defined in CONF/flume-env.sh is not a good answer.


Summary
-------

regression refers to FLUME_HOME before it's defined.


This addresses bug FLUME-1130.
    https://issues.apache.org/jira/browse/FLUME-1130


Diffs (updated)
-----

  bin/flume-ng 39f6b05 

Diff: https://reviews.apache.org/r/4795/diff


Testing
-------

Basic startup works again.


Thanks,

Mike


                
> flume-ng script bad ordering on FLUME_HOME var
> ----------------------------------------------
>
>                 Key: FLUME-1130
>                 URL: https://issues.apache.org/jira/browse/FLUME-1130
>             Project: Flume
>          Issue Type: Bug
>            Reporter: Mike Percy
>            Assignee: Mike Percy
>             Fix For: v1.2.0
>
>         Attachments: FLUME-1130-1.patch
>
>
> Previous patch to flume-ng script had some ordering issues (FLUME_HOME 
> referenced before being defined).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to