----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4800/#review7038 -----------------------------------------------------------
Ship it! lgtm - Prasad On 2012-04-19 05:42:55, Hari Shreedharan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4800/ > ----------------------------------------------------------- > > (Updated 2012-04-19 05:42:55) > > > Review request for Flume. > > > Summary > ------- > > Using futures to cancel the monitor threads, instead of remove. > > > This addresses bug FLUME-1136. > https://issues.apache.org/jira/browse/FLUME-1136 > > > Diffs > ----- > > > flume-ng-core/src/main/java/org/apache/flume/lifecycle/LifecycleSupervisor.java > 8978087 > > Diff: https://reviews.apache.org/r/4800/diff > > > Testing > ------- > > Unit tests pass. Functional testing done. > > > Thanks, > > Hari > >
