[
https://issues.apache.org/jira/browse/FLUME-1136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13257617#comment-13257617
]
[email protected] commented on FLUME-1136:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4800/#review7038
-----------------------------------------------------------
Ship it!
lgtm
- Prasad
On 2012-04-19 05:42:55, Hari Shreedharan wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4800/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-04-19 05:42:55)
bq.
bq.
bq. Review request for Flume.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Using futures to cancel the monitor threads, instead of remove.
bq.
bq.
bq. This addresses bug FLUME-1136.
bq. https://issues.apache.org/jira/browse/FLUME-1136
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
flume-ng-core/src/main/java/org/apache/flume/lifecycle/LifecycleSupervisor.java
8978087
bq.
bq. Diff: https://reviews.apache.org/r/4800/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Unit tests pass. Functional testing done.
bq.
bq.
bq. Thanks,
bq.
bq. Hari
bq.
bq.
> Remove from executor service does not always remove the runnables from the
> queue
> --------------------------------------------------------------------------------
>
> Key: FLUME-1136
> URL: https://issues.apache.org/jira/browse/FLUME-1136
> Project: Flume
> Issue Type: Bug
> Components: Node
> Affects Versions: v1.1.0
> Reporter: Hari Shreedharan
> Assignee: Hari Shreedharan
> Priority: Minor
> Fix For: v1.2.0
>
> Attachments: FLUME-1136.patch
>
>
> It seems like ScheduledThreadPoolExecutor's remove() function sometimes does
> not remove the runnable specified. This does not cause any functionality
> problems, just spills lot of stuff into logs during reconfiguration, and can
> cause runnables to be executed unnecessarily, even though they return
> immediately.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
