-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4837/
-----------------------------------------------------------

Review request for Flume.


Summary
-------

ChannelProcessor did not handle transactions well, in some cases if anything 
but ChannelException was thrown, the close in the finally would throw an 
exception as rollback was not called. In other cases if a subclass of error was 
thrown the same would occurred. Additionally, if getTransaction threw an 
exception the null transaction value was not handled and an NPE would be thrown.


This addresses bug FLUME-1131.
    https://issues.apache.org/jira/browse/FLUME-1131


Diffs
-----

  
flume-ng-core/src/test/java/org/apache/flume/channel/TestChannelProcessor.java 
PRE-CREATION 
  flume-ng-core/pom.xml b9f1e12 
  flume-ng-core/src/main/java/org/apache/flume/channel/ChannelProcessor.java 
eb6460e 

Diff: https://reviews.apache.org/r/4837/diff


Testing
-------

Tests added and tests pass.


Thanks,

Brock

Reply via email to