----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4762/#review7151 -----------------------------------------------------------
Ship it! +1 Changes look good Mike. Please open a follow-up Jira to enhance the test case so that it fails in case the compression does not kick in. - Arvind On 2012-04-18 01:58:33, Mike Percy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4762/ > ----------------------------------------------------------- > > (Updated 2012-04-18 01:58:33) > > > Review request for Flume. > > > Summary > ------- > > Add configuration support to AbstractAvroEventSerializer for Avro sync > interval and compression support. > > > This addresses bug FLUME-1127. > https://issues.apache.org/jira/browse/FLUME-1127 > > > Diffs > ----- > > > flume-ng-core/src/main/java/org/apache/flume/serialization/AbstractAvroEventSerializer.java > a0884b2 > > flume-ng-core/src/main/java/org/apache/flume/serialization/AvroEventSerializerConfigurationConstants.java > PRE-CREATION > > flume-ng-core/src/test/java/org/apache/flume/serialization/TestFlumeEventAvroEventSerializer.java > ff381be > > flume-ng-core/src/test/java/org/apache/flume/serialization/TestSyslogAvroEventSerializer.java > 0cbf08a > > Diff: https://reviews.apache.org/r/4762/diff > > > Testing > ------- > > Added unit tests. Also did manual verification of the compression codec on > the output files. > > > Thanks, > > Mike > >
