----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4622/#review7157 -----------------------------------------------------------
Ship it! Looks good Inder. Some minor nits noted below. Once you address them, please attach the updated patch to the Jira. trunk/flume-ng-core/src/main/java/org/apache/flume/client/avro/AvroCLIClient.java <https://reviews.apache.org/r/4622/#comment15799> better log the exception as well: logger.debug("Unable to load file: " + headerFile, e); trunk/flume-ng-core/src/main/java/org/apache/flume/client/avro/AvroCLIClient.java <https://reviews.apache.org/r/4622/#comment15798> convention nit: finally on the same line as the preceding curly brace: ... } finally { ... } trunk/flume-ng-core/src/main/java/org/apache/flume/client/avro/AvroCLIClient.java <https://reviews.apache.org/r/4622/#comment15800> better to log the exception here stating unable to close file. - Arvind On 2012-04-23 18:09:31, Inder Singh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4622/ > ----------------------------------------------------------- > > (Updated 2012-04-23 18:09:31) > > > Review request for Flume, Arvind Prabhakar and Mike Percy. > > > Summary > ------- > > Patch to address FLUME 1096. Please review and share your thoughts. > > > This addresses bug https://issues.apache.org/jira/browse/FLUME-1096. > > https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/FLUME-1096 > > > Diffs > ----- > > trunk/bin/flume-ng 1329352 > > trunk/flume-ng-core/src/main/java/org/apache/flume/client/avro/AvroCLIClient.java > 1329352 > > Diff: https://reviews.apache.org/r/4622/diff > > > Testing > ------- > > 1. Configured flume agent to publish data in /data/flume/%D > 2. ran the avroClient to stream some data. > 3. Things looked ok. Data was available in HDFS. > > > Thanks, > > Inder > >
