[
https://issues.apache.org/jira/browse/FLUME-1057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13260156#comment-13260156
]
[email protected] commented on FLUME-1057:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4507/#review7162
-----------------------------------------------------------
Ship it!
Looks good.
Being super-picky I would say you could maybe move the port and batchsize null
checks next to the places where they are actually set for code clarity.
- Juhani
On 2012-03-27 06:25:18, Hari Shreedharan wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4507/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-03-27 06:25:18)
bq.
bq.
bq. Review request for Flume.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Avrosink conf
bq.
bq.
bq. This addresses bug FLUME-1057.
bq. https://issues.apache.org/jira/browse/FLUME-1057
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/AvroSinkConfiguration.java
PRE-CREATION
bq. flume-ng-core/src/main/java/org/apache/flume/sink/AvroSink.java 3edc563
bq.
bq. Diff: https://reviews.apache.org/r/4507/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Hari
bq.
bq.
> AvroSink configuration
> ----------------------
>
> Key: FLUME-1057
> URL: https://issues.apache.org/jira/browse/FLUME-1057
> Project: Flume
> Issue Type: Sub-task
> Reporter: Hari Shreedharan
> Assignee: Hari Shreedharan
> Fix For: v1.2.0
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
