[
https://issues.apache.org/jira/browse/FLUME-1142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13260728#comment-13260728
]
[email protected] commented on FLUME-1142:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4849/#review7178
-----------------------------------------------------------
Hari, even though this is not related to your change, it will be better if you
can address the following as well with your patch:
flume-ng-configuration/src/main/java/org/apache/flume/conf/source/SourceConfiguration.java
<https://reviews.apache.org/r/4849/#comment15837>
This seems to be incorrect.
flume-ng-configuration/src/main/java/org/apache/flume/conf/source/SourceConfiguration.java
<https://reviews.apache.org/r/4849/#comment15838>
convention nit: please place else on the same line as the preceding curly
brace:
...
} else {
...
- Arvind
On 2012-04-24 00:56:30, Hari Shreedharan wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4849/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-04-24 00:56:30)
bq.
bq.
bq. Review request for Flume and Arvind Prabhakar.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Minor fix for seq source not working with multiplexing channel selector.
bq.
bq.
bq. This addresses bug FLUME-1142.
bq. https://issues.apache.org/jira/browse/FLUME-1142
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
flume-ng-configuration/src/main/java/org/apache/flume/conf/source/SourceConfiguration.java
924fc05
bq.
bq. Diff: https://reviews.apache.org/r/4849/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Ran a node with seq source and multiplexing channel selector.
bq.
bq.
bq. Thanks,
bq.
bq. Hari
bq.
bq.
> Seq source fails with multiplexing channel selector
> ---------------------------------------------------
>
> Key: FLUME-1142
> URL: https://issues.apache.org/jira/browse/FLUME-1142
> Project: Flume
> Issue Type: Bug
> Affects Versions: v1.2.0
> Reporter: Hari Shreedharan
> Assignee: Hari Shreedharan
> Priority: Minor
> Fix For: v1.2.0
>
> Attachments: FLUME-1142.patch
>
>
> After the new conf changes, seq source will fail with multiplexing channel
> selector.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
