Will McQueen created FLUME-1148:
-----------------------------------

             Summary: Refactor logging
                 Key: FLUME-1148
                 URL: https://issues.apache.org/jira/browse/FLUME-1148
             Project: Flume
          Issue Type: Bug
          Components: Configuration
    Affects Versions: v1.2.0
         Environment: [CentOS 6.2 64-bit]
            Reporter: Will McQueen
             Fix For: v1.2.0


[Marke ]
[Tested with the sample config template]

1. WARN msg is printed in the logs, when it shouldn't be a warning... maybe 
just INFO:
2012-04-24 19:56:59,370 (conf-file-poller-0) [WARN - 
org.apache.flume.conf.FlumeConfiguration$AgentConfiguration.validateSinks(FlumeConfiguration.java:591)]
 Sink: loggerSink

2. The initial (prevalidation) config should show the props that were read from 
the config file before validation, rather than showing an empty list.
2012-04-24 19:56:59,353 (conf-file-poller-0) [DEBUG - 
org.apache.flume.conf.FlumeConfiguration$AgentConfiguration.isValid(FlumeConfiguration.java:284)]
 Starting validation of configuration for agent: agent, initial-configuration: 
AgentConfiguration[agent]
SOURCES: {}
CHANNELS: {}
SINKS: {}

3. The final (post-validation) config should be pretty-printed, like the 
initial config. Currently it looks like this:
2012-04-24 19:56:59,389 (conf-file-poller-0) [INFO - 
org.apache.flume.node.nodemanager.DefaultLogicalNodeManager.onNodeConfigurationChanged(DefaultLogicalNodeManager.java:54)]
 Node configuration change:{ sourceRunners:{seqGenSrc=PollableSourceRunner: { 
source:org.apache.flume.source.SequenceGeneratorSource@450e790c counterGroup:{ 
name:null counters:{} } }} sinkRunners:{loggerSink=SinkRunner: { 
policy:org.apache.flume.sink.DefaultSinkProcessor@392d263f counterGroup:{ 
name:null counters:{} } }} 
channels:{memoryChannel=org.apache.flume.channel.MemoryChannel@432a0f6c} }


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to