-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4870/
-----------------------------------------------------------
Review request for Flume.
Summary
-------
Changed the way we log during configuration validation.
This addresses bug FLUME-1148.
https://issues.apache.org/jira/browse/FLUME-1148
Diffs
-----
flume-ng-configuration/src/main/java/org/apache/flume/conf/ComponentConfiguration.java
97ac302
flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfiguration.java
881c0fa
flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/SinkConfiguration.java
ac4d3a3
flume-ng-configuration/src/main/java/org/apache/flume/conf/source/SourceConfiguration.java
24b4e1c
Diff: https://reviews.apache.org/r/4870/diff
Testing
-------
Ran an agent with template configuration. In the following log, lines between
<-- and --> were added here(they arent part of the log):
2012-04-24 23:14:20,840 (conf-file-poller-0) [DEBUG -
org.apache.flume.conf.FlumeConfiguration$AgentConfiguration.isValid(FlumeConfiguration.java:284)]
Starting validation of configuration for agent: agent, initial-configuration:
AgentConfiguration[agent]
SOURCES: {seqGenSrc={ parameters:{channels=memoryChannel, type=seq} }}
CHANNELS: {memoryChannel={ parameters:{capacity=100, type=memory} }}
SINKS: {loggerSink={ parameters:{type=logger, channel=memoryChannel} }}
<--This stuff is what we read from the conf file. It has not yet been
validated, therefore we say initial configuration(this is the same as before,
just format changed)-->
2012-04-24 23:14:20,846 (conf-file-poller-0) [DEBUG -
org.apache.flume.conf.FlumeConfiguration$AgentConfiguration.validateChannels(FlumeConfiguration.java:438)]
Created channel memoryChannel
2012-04-24 23:14:20,860 (conf-file-poller-0) [DEBUG -
org.apache.flume.conf.FlumeConfiguration$AgentConfiguration.validateSinks(FlumeConfiguration.java:617)]
Creating sink: loggerSink using LOGGER
<--The following is post validation-->
2012-04-24 23:14:20,864 (conf-file-poller-0) [DEBUG -
org.apache.flume.conf.FlumeConfiguration$AgentConfiguration.isValid(FlumeConfiguration.java:342)]
Post validation configuration for agent
AgentConfiguration created without Configuration stubs for which only basic
syntactical validation was performed[agent]
SOURCES: {seqGenSrc={ parameters:{channels=memoryChannel, type=seq} }}
CHANNELS: {memoryChannel={ parameters:{capacity=100, type=memory} }}
<--This stuff - we couldn't find config stubs for these. We did basic syntactic
validation, and found them to be ok. Since no sinks belong to this
category(because we could do component specific validation), there is no sinks
section. If there was a sink, whcih we could do only Syntactic validation, even
that would appear here -->
AgentConfiguration created with Configuration stubs for which full
validation was performed[agent]
SINKS: {loggerSink=ComponentConfiguration[loggerSink]
CONFIG:
CHANNEL:memoryChannel
}
<--We could do a more thorough component specific validation of this stuff.
Since we couldn't do component specific validation of any channels, or sources,
they aren't listed. If we could, then there would be a section for that and it
would be listed like SOURCES: <blah> -->
Thanks,
Hari
