----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4872/#review7208 -----------------------------------------------------------
Ship it! lgtm! I confirmed the fix works. Below is the config I used. I had to make sure to first create the /home/will/results1 and /home/will/results2 dirs before starting the agent. Then I started the agent, waited for each of the 2 files to be created, and tailed them in diff't terminals. Then I launched interactive netcat terminals in each of 2 consoles: nc localhost 1473 nc localhost 1474 Before the patch, I entered "0" into the first console going to port 1473, and the "0" was logged to both sources. After the patch, I entered "0" into the first console going to port 1473, and "0" appeared only for src1 destination. Then I entered "1" into second console going to port 1474, and "1" appeared only for src2 destination. # a = agent # c = channel # r = source # k = sink # g = sink group agent.channels = c1 c2 agent.sources = r1 r2 agent.sinks = k1 k2 agent.channels.c1.type = MEMORY agent.channels.c2.type = MEMORY agent.sources.r1.type = NETCAT agent.sources.r1.channels = c1 agent.sources.r1.bind = 0.0.0.0 agent.sources.r1.port = 1473 agent.sources.r2.type = NETCAT agent.sources.r2.channels = c2 agent.sources.r2.bind = 0.0.0.0 agent.sources.r2.port = 1474 agent.sinks.k1.channel = c1 agent.sinks.k1.type = FILE_ROLL agent.sinks.k1.sink.directory = /home/will/results1 agent.sinks.k1.sink.rollInterval = 0 agent.sinks.k2.channel = c2 agent.sinks.k2.type = FILE_ROLL agent.sinks.k2.sink.directory = /home/will/results2 agent.sinks.k2.sink.rollInterval = 0 - Will On 2012-04-25 09:51:43, Hari Shreedharan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4872/ > ----------------------------------------------------------- > > (Updated 2012-04-25 09:51:43) > > > Review request for Flume. > > > Summary > ------- > > Even if config specifies different files, all sources end up writing to all > channels. Fixed it. > > > This addresses bug FLUME-1149. > https://issues.apache.org/jira/browse/FLUME-1149 > > > Diffs > ----- > > > flume-ng-node/src/main/java/org/apache/flume/conf/properties/PropertiesFileConfigurationProvider.java > c0f83e4 > > Diff: https://reviews.apache.org/r/4872/diff > > > Testing > ------- > > Functional testing with multiple channels. > > > Thanks, > > Hari > >
