[ 
https://issues.apache.org/jira/browse/FLUME-1149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13261425#comment-13261425
 ] 

[email protected] commented on FLUME-1149:
------------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4872/#review7209
-----------------------------------------------------------

Ship it!


Looks good to me, verified that a config similar to Will's does not produce the 
previous doubling behavior. Thanks for the fix Hari!

- Mike


On 2012-04-25 09:51:43, Hari Shreedharan wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/4872/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2012-04-25 09:51:43)
bq.  
bq.  
bq.  Review request for Flume.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  Even if config specifies different files, all sources end up writing to 
all channels. Fixed it.
bq.  
bq.  
bq.  This addresses bug FLUME-1149.
bq.      https://issues.apache.org/jira/browse/FLUME-1149
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    
flume-ng-node/src/main/java/org/apache/flume/conf/properties/PropertiesFileConfigurationProvider.java
 c0f83e4 
bq.  
bq.  Diff: https://reviews.apache.org/r/4872/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  Functional testing with multiple channels.
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Hari
bq.  
bq.


                
> All sources get same channel list even if configuration is different.
> ---------------------------------------------------------------------
>
>                 Key: FLUME-1149
>                 URL: https://issues.apache.org/jira/browse/FLUME-1149
>             Project: Flume
>          Issue Type: Bug
>          Components: Sinks+Sources
>    Affects Versions: v1.2.0
>            Reporter: Hari Shreedharan
>            Assignee: Hari Shreedharan
>             Fix For: v1.2.0
>
>         Attachments: FLUME-1149-1.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to