----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4809/#review7303 -----------------------------------------------------------
Ship it! +1 Changes look good Prasad. Some nits noted below. Once you are done with the revision, please update the patch on the Jira. flume-ng-core/src/main/java/org/apache/flume/source/SyslogUtils.java <https://reviews.apache.org/r/4809/#comment16126> convention: rename to messageFormats instead of using underscore. flume-ng-core/src/main/java/org/apache/flume/source/SyslogUtils.java <https://reviews.apache.org/r/4809/#comment16125> convention: please use class name with CamelCase (SyslogFormater) flume-ng-core/src/main/java/org/apache/flume/source/SyslogUtils.java <https://reviews.apache.org/r/4809/#comment16127> nit: please rename it to initHeaderFormats() instead. flume-ng-core/src/main/java/org/apache/flume/source/SyslogUtils.java <https://reviews.apache.org/r/4809/#comment16124> nit: please remove extraneous whitespace. flume-ng-core/src/test/java/org/apache/flume/source/TestSyslogUtils.java <https://reviews.apache.org/r/4809/#comment16128> nit:trailing whitespace. - Arvind On 2012-04-27 14:58:21, Prasad Mujumdar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4809/ > ----------------------------------------------------------- > > (Updated 2012-04-27 14:58:21) > > > Review request for Flume, Arvind Prabhakar and Mike Percy. > > > Summary > ------- > > Support for timestamp and hostname parsing. > > > This addresses bug FLUME-1126. > https://issues.apache.org/jira/browse/FLUME-1126 > > > Diffs > ----- > > flume-ng-core/src/main/java/org/apache/flume/source/SyslogTcpSource.java > b0485b1 > flume-ng-core/src/main/java/org/apache/flume/source/SyslogUDPSource.java > 732cce5 > flume-ng-core/src/main/java/org/apache/flume/source/SyslogUtils.java > 653f5eb > flume-ng-core/src/test/java/org/apache/flume/source/TestSyslogUtils.java > 8b1f7c5 > > Diff: https://reviews.apache.org/r/4809/diff > > > Testing > ------- > > Updated syslog tests to cover timestamp and hostname handling. > Manually tested using syslog4j > > > Thanks, > > Prasad > >
