[
https://issues.apache.org/jira/browse/FLUME-1156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13263792#comment-13263792
]
[email protected] commented on FLUME-1156:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4897/#review7308
-----------------------------------------------------------
Ship it!
+1
Will commit if tests pass.
- Arvind
On 2012-04-26 20:00:16, Hari Shreedharan wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4897/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-04-26 20:00:16)
bq.
bq.
bq. Review request for Flume.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Fixed by checking for null or empty string before splitting it.
bq.
bq.
bq. This addresses bug Flume-1156.
bq. https://issues.apache.org/jira/browse/Flume-1156
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfiguration.java
695ad60
bq.
bq. Diff: https://reviews.apache.org/r/4897/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Ran an agent with null source string. Looks ok
bq.
bq.
bq. Thanks,
bq.
bq. Hari
bq.
bq.
> If config file has empty sources, then throws NPE
> -------------------------------------------------
>
> Key: FLUME-1156
> URL: https://issues.apache.org/jira/browse/FLUME-1156
> Project: Flume
> Issue Type: Bug
> Components: Configuration
> Affects Versions: v1.2.0
> Reporter: Will McQueen
> Assignee: Hari Shreedharan
> Fix For: v1.2.0
>
> Attachments: FLUME-1156.patch
>
>
> Config file used:
> agent.channels = c1
> agent.sources =
> agent.sinks = k1
> agent.channels.c1.type = MEMORY
> agent.sources.r1.channels = c1
> agent.sources.r1.type = SEQ
> agent.sinks.k1.channels = c1
> agent.sinks.k1.type = NULL
> 2012-04-26 12:08:52,382 (conf-file-poller-0) [ERROR -
> org.apache.flume.conf.file.AbstractFileConfigurationProvider$FileWatcherRunnable.run(AbstractFileConfigurationProvider.java:205)]
> Failed to load configuration data. Exception follows.
> java.lang.NullPointerException
> at
> org.apache.flume.conf.FlumeConfiguration$AgentConfiguration.validateSources(FlumeConfiguration.java:475)
> at
> org.apache.flume.conf.FlumeConfiguration$AgentConfiguration.isValid(FlumeConfiguration.java:316)
> at
> org.apache.flume.conf.FlumeConfiguration$AgentConfiguration.access$000(FlumeConfiguration.java:205)
> at
> org.apache.flume.conf.FlumeConfiguration.validateConfiguration(FlumeConfiguration.java:119)
> at
> org.apache.flume.conf.FlumeConfiguration.<init>(FlumeConfiguration.java:101)
> at
> org.apache.flume.conf.properties.PropertiesFileConfigurationProvider.load(PropertiesFileConfigurationProvider.java:214)
> at
> org.apache.flume.conf.file.AbstractFileConfigurationProvider.doLoad(AbstractFileConfigurationProvider.java:124)
> at
> org.apache.flume.conf.file.AbstractFileConfigurationProvider.access$300(AbstractFileConfigurationProvider.java:38)
> at
> org.apache.flume.conf.file.AbstractFileConfigurationProvider$FileWatcherRunnable.run(AbstractFileConfigurationProvider.java:203)
> at
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:441)
> at
> java.util.concurrent.FutureTask$Sync.innerRunAndReset(FutureTask.java:317)
> at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:150)
> at
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$101(ScheduledThreadPoolExecutor.java:98)
> at
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.runPeriodic(ScheduledThreadPoolExecutor.java:180)
> at
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:204)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
> at java.lang.Thread.run(Thread.java:662)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
