[
https://issues.apache.org/jira/browse/FLUME-1160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13264435#comment-13264435
]
[email protected] commented on FLUME-1160:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4927/#review7366
-----------------------------------------------------------
Ship it!
lgtm, attache the patch to the jira if not already there
- Brock
On 2012-04-28 21:36:08, Hari Shreedharan wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4927/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-04-28 21:36:08)
bq.
bq.
bq. Review request for Flume and Brock Noland.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Actually nothing in that try block would throw an NPE, so removing it. To
clarify:
bq. * a check for type being null is done before entering this code.
bq. * valueOf throws an IllegalArgumentException if the type cannot be
found(which is caught and rethrown)
bq. * All of the getConfiguration functions *will* return a configuration
object(or throw) and not return null.
bq.
bq.
bq. This addresses bug FLUME-1160.
bq. https://issues.apache.org/jira/browse/FLUME-1160
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
flume-ng-configuration/src/main/java/org/apache/flume/conf/ComponentConfigurationFactory.java
c495cde
bq.
bq. Diff: https://reviews.apache.org/r/4927/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Hari
bq.
bq.
> ComponentConfigurationFactory catches NullPointerException
> ----------------------------------------------------------
>
> Key: FLUME-1160
> URL: https://issues.apache.org/jira/browse/FLUME-1160
> Project: Flume
> Issue Type: Improvement
> Components: Configuration
> Affects Versions: v1.2.0
> Reporter: Brock Noland
> Assignee: Hari Shreedharan
> Attachments: FLUME-1160.patch
>
>
> Catching NPE and then returning null is super hard to debug when there is an
> actual bug. We should put the appropriate null checks in place so we don't
> have to catch NPE.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
