> On 2012-04-28 23:27:37, Brock Noland wrote: > > lgtm, attache the patch to the jira if not already there
Thanks Brock! Already attached. - Hari ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4927/#review7366 ----------------------------------------------------------- On 2012-04-28 21:36:08, Hari Shreedharan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4927/ > ----------------------------------------------------------- > > (Updated 2012-04-28 21:36:08) > > > Review request for Flume and Brock Noland. > > > Summary > ------- > > Actually nothing in that try block would throw an NPE, so removing it. To > clarify: > * a check for type being null is done before entering this code. > * valueOf throws an IllegalArgumentException if the type cannot be > found(which is caught and rethrown) > * All of the getConfiguration functions *will* return a configuration > object(or throw) and not return null. > > > This addresses bug FLUME-1160. > https://issues.apache.org/jira/browse/FLUME-1160 > > > Diffs > ----- > > > flume-ng-configuration/src/main/java/org/apache/flume/conf/ComponentConfigurationFactory.java > c495cde > > Diff: https://reviews.apache.org/r/4927/diff > > > Testing > ------- > > > Thanks, > > Hari > >
