----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4838/#review7457 -----------------------------------------------------------
Ship it! +1 Changes look good. A couple of nits noted below. flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/HDFSEventSink.java <https://reviews.apache.org/r/4838/#comment16464> nit: the callWithTimeoutLogError adds a prefix to the log message as "Error calling " + name. This translates to a message in this case like:"Error calling Calling flush on ...". Suggest removing the redundant words here and keeping the name to "flush on " + callableWriter. flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/HDFSEventSink.java <https://reviews.apache.org/r/4838/#comment16465> nit: "close on " + e.getKey() - Arvind On 2012-04-22 23:17:45, Brock Noland wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4838/ > ----------------------------------------------------------- > > (Updated 2012-04-22 23:17:45) > > > Review request for Flume. > > > Summary > ------- > > Message is logged a large volume of times and is incorrect. > > > This addresses bug FLUME-1132. > https://issues.apache.org/jira/browse/FLUME-1132 > > > Diffs > ----- > > > flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/HDFSEventSink.java > 1b61cad > > Diff: https://reviews.apache.org/r/4838/diff > > > Testing > ------- > > Logging only change > > > Thanks, > > Brock > >
