[ 
https://issues.apache.org/jira/browse/FLUME-1132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13266650#comment-13266650
 ] 

[email protected] commented on FLUME-1132:
------------------------------------------------------



bq.  On 2012-05-02 00:20:27, Arvind Prabhakar wrote:
bq.  > +1 Changes look good. A couple of nits noted below.

Resolve both nits and attached to JIRA. Thank you for your review!


- Brock


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4838/#review7457
-----------------------------------------------------------


On 2012-04-22 23:17:45, Brock Noland wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/4838/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2012-04-22 23:17:45)
bq.  
bq.  
bq.  Review request for Flume.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  Message is logged a large volume of times and is incorrect.
bq.  
bq.  
bq.  This addresses bug FLUME-1132.
bq.      https://issues.apache.org/jira/browse/FLUME-1132
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    
flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/HDFSEventSink.java
 1b61cad 
bq.  
bq.  Diff: https://reviews.apache.org/r/4838/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  Logging only change
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Brock
bq.  
bq.


                
> HDFSEventSink has spurious and verbose log message
> --------------------------------------------------
>
>                 Key: FLUME-1132
>                 URL: https://issues.apache.org/jira/browse/FLUME-1132
>             Project: Flume
>          Issue Type: Improvement
>    Affects Versions: v1.1.0
>            Reporter: Brock Noland
>            Assignee: Brock Noland
>         Attachments: FLUME-1132-0.patch, FLUME-1132-1.patch
>
>
> The finally block in HDFSEvent sink when calling flush prints "Calling abort 
> on ...". This is incorrect as it's actually calling flush and is logged a 
> tremendous number of times.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to