[
https://issues.apache.org/jira/browse/FLUME-1146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13266778#comment-13266778
]
[email protected] commented on FLUME-1146:
------------------------------------------------------
bq. On 2012-05-02 17:54:34, Arvind Prabhakar wrote:
bq. > Thanks for the patch Hari. I am not sure if this is working though. Here
is the dependencies generated after applying this patch for log4jappender:
bq. >
bq. > avro-1.6.1.jar
bq. > avro-ipc-1.6.1.jar
bq. > commons-codec-1.3.jar
bq. > commons-collections-3.2.1.jar
bq. > commons-io-2.1.jar
bq. > commons-lang-2.4.jar
bq. > commons-logging-1.1.1.jar
bq. > commons-pool-1.5.4.jar
bq. > flume-ng-sdk-1.2.0-incubating-SNAPSHOT.jar
bq. > httpclient-4.0.1.jar
bq. > httpcore-4.0.1.jar
bq. > jetty-6.1.26.jar
bq. > jetty-util-6.1.26.jar
bq. > jsr305-1.3.9.jar
bq. > log4j-1.2.16.jar
bq. > netty-3.2.6.Final.jar
bq. > paranamer-2.3.jar
bq. > servlet-api-2.5-20081211.jar
bq. > servlet-api-2.5.jar
bq. > snappy-java-1.0.4.1.jar
bq. > velocity-1.7.jar
bq. >
bq. > Some of these are not needed, and some of the needed ones are getting
excluded. Here is what I feel are the required dependencies for the log4j
appender:
bq. >
bq. > avro-1.6.1.jar
bq. > avro-ipc-1.6.1.jar
bq. > flume-ng-log4jappender-1.2.0-incubating-SNAPSHOT.jar
bq. > flume-ng-sdk-1.2.0-incubating-SNAPSHOT.jar
bq. > jackson-core-asl-1.9.3.jar
bq. > jackson-mapper-asl-1.9.3.jar
bq. > log4j-1.2.16.jar
bq. > netty-3.2.6.Final.jar
bq. > slf4j-api-1.6.1.jar
bq. >
bq. > As you can see the jackson and slf4j are missing, while a host of other
libs are getting included that are not needed.
bq. >
bq. >
Hi Arvind,
Thanks for the feedback. It was a bit difficult to work around some of the
maven issues. Maven is for some reason, unable to pull in transitive
dependencies of includes which are added as depedencies, even if
<useTransitiveFiltering> is set to false. If you know some way to get
transitive dependencies to get included, please let me know. I will submit a
patch with that approach.
- Hari
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4871/#review7476
-----------------------------------------------------------
On 2012-04-26 02:52:24, Hari Shreedharan wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4871/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-04-26 02:52:24)
bq.
bq.
bq. Review request for Flume.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Move log4jappender to another folder.
bq.
bq.
bq. This addresses bug FLUME-1146.
bq. https://issues.apache.org/jira/browse/FLUME-1146
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. flume-ng-dist/src/main/assembly/dist.xml 98f48fb
bq.
bq. Diff: https://reviews.apache.org/r/4871/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Hari
bq.
bq.
> Standalone clients like log4jappender should go into a different folder in
> the distribution
> -------------------------------------------------------------------------------------------
>
> Key: FLUME-1146
> URL: https://issues.apache.org/jira/browse/FLUME-1146
> Project: Flume
> Issue Type: Improvement
> Components: Build
> Reporter: Hari Shreedharan
> Assignee: Hari Shreedharan
> Priority: Minor
> Attachments: FLUME-1146-1.patch, FLUME-1146.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
