> On 2012-05-02 17:54:34, Arvind Prabhakar wrote: > > Thanks for the patch Hari. I am not sure if this is working though. Here is > > the dependencies generated after applying this patch for log4jappender: > > > > avro-1.6.1.jar > > avro-ipc-1.6.1.jar > > commons-codec-1.3.jar > > commons-collections-3.2.1.jar > > commons-io-2.1.jar > > commons-lang-2.4.jar > > commons-logging-1.1.1.jar > > commons-pool-1.5.4.jar > > flume-ng-sdk-1.2.0-incubating-SNAPSHOT.jar > > httpclient-4.0.1.jar > > httpcore-4.0.1.jar > > jetty-6.1.26.jar > > jetty-util-6.1.26.jar > > jsr305-1.3.9.jar > > log4j-1.2.16.jar > > netty-3.2.6.Final.jar > > paranamer-2.3.jar > > servlet-api-2.5-20081211.jar > > servlet-api-2.5.jar > > snappy-java-1.0.4.1.jar > > velocity-1.7.jar > > > > Some of these are not needed, and some of the needed ones are getting > > excluded. Here is what I feel are the required dependencies for the log4j > > appender: > > > > avro-1.6.1.jar > > avro-ipc-1.6.1.jar > > flume-ng-log4jappender-1.2.0-incubating-SNAPSHOT.jar > > flume-ng-sdk-1.2.0-incubating-SNAPSHOT.jar > > jackson-core-asl-1.9.3.jar > > jackson-mapper-asl-1.9.3.jar > > log4j-1.2.16.jar > > netty-3.2.6.Final.jar > > slf4j-api-1.6.1.jar > > > > As you can see the jackson and slf4j are missing, while a host of other > > libs are getting included that are not needed. > > > > > > Hari Shreedharan wrote: > Hi Arvind, > > Thanks for the feedback. It was a bit difficult to work around some of > the maven issues. Maven is for some reason, unable to pull in transitive > dependencies of includes which are added as depedencies, even if > <useTransitiveFiltering> is set to false. If you know some way to get > transitive dependencies to get included, please let me know. I will submit a > patch with that approach.
The reason these dependencies are getting pulled in is because these are marked as dependencies in parent pom, and hence, in the effective pom of the log4j appender. So if we add the includes of the log4jappender specifically and then pull its transitive dependencies, it would work fine. - Hari ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4871/#review7476 ----------------------------------------------------------- On 2012-04-26 02:52:24, Hari Shreedharan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4871/ > ----------------------------------------------------------- > > (Updated 2012-04-26 02:52:24) > > > Review request for Flume. > > > Summary > ------- > > Move log4jappender to another folder. > > > This addresses bug FLUME-1146. > https://issues.apache.org/jira/browse/FLUME-1146 > > > Diffs > ----- > > flume-ng-dist/src/main/assembly/dist.xml 98f48fb > > Diff: https://reviews.apache.org/r/4871/diff > > > Testing > ------- > > > Thanks, > > Hari > >
