[
https://issues.apache.org/jira/browse/FLUME-1131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13268991#comment-13268991
]
[email protected] commented on FLUME-1131:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4837/
-----------------------------------------------------------
(Updated 2012-05-05 15:44:22.206077)
Review request for Flume.
Changes
-------
Updated patch which addresses the review items.
Summary
-------
ChannelProcessor did not handle transactions well, in some cases if anything
but ChannelException was thrown, the close in the finally would throw an
exception as rollback was not called. In other cases if a subclass of error was
thrown the same would occurred. Additionally, if getTransaction threw an
exception the null transaction value was not handled and an NPE would be thrown.
This addresses bug FLUME-1131.
https://issues.apache.org/jira/browse/FLUME-1131
Diffs (updated)
-----
flume-ng-core/pom.xml b798b34
flume-ng-core/src/main/java/org/apache/flume/channel/ChannelProcessor.java
eb6460e
flume-ng-core/src/test/java/org/apache/flume/channel/TestChannelProcessor.java
PRE-CREATION
Diff: https://reviews.apache.org/r/4837/diff
Testing
-------
Tests added and tests pass.
Thanks,
Brock
> ChannelProcessor does not handle transactions appropriately
> -----------------------------------------------------------
>
> Key: FLUME-1131
> URL: https://issues.apache.org/jira/browse/FLUME-1131
> Project: Flume
> Issue Type: Bug
> Affects Versions: v1.1.0
> Reporter: Brock Noland
> Assignee: Brock Noland
> Attachments: FLUME-1131-0.patch
>
>
> If an Exception is thrown in ChannelProcessor.processEvent whilst getting an
> exception, tx will be null and when rollback is called on tx, an NPE will be
> thrown.
> {noformat}
> 12/04/18 19:03:17 ERROR source.PollableSourceRunner: Unhandled exception,
> logging and sleeping for 5000ms
> java.lang.NullPointerException
> at
> org.apache.flume.channel.ChannelProcessor.processEvent(ChannelProcessor.java:183)
> at
> org.apache.flume.source.SequenceGeneratorSource.process(SequenceGeneratorSource.java:48)
> at
> org.apache.flume.source.PollableSourceRunner$PollingRunner.run(PollableSourceRunner.java:131)
> at java.lang.Thread.run(Thread.java:662)
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
