[ 
https://issues.apache.org/jira/browse/FLUME-1174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13269215#comment-13269215
 ] 

[email protected] commented on FLUME-1174:
------------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5046/
-----------------------------------------------------------

(Updated 2012-05-06 13:21:54.403887)


Review request for Flume.


Changes
-------

trailing spaces removed


Summary
-------

FLUME-1174 describes an error when Flume is built on Windows machines. The 
error occurs through hardcoded test cases which assume a /etc/passwd file and a 
hardcoded /tmp path. As revealed in the Jira that could be an security issue. 
On top it makes it impossible to build Flume on non standard Linux operating 
systems (including Busy Box, grml, Windows etc). 


This addresses bug FLUME-1174.
    https://issues.apache.org/jira/browse/FLUME-1174


Diffs (updated)
-----

  flume-ng-core/src/test/java/org/apache/flume/source/TestExecSource.java 
615f2a3 

Diff: https://reviews.apache.org/r/5046/diff


Testing
-------

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] 
[INFO] Apache Flume ...................................... SUCCESS [1.575s]
[INFO] Flume NG SDK ...................................... SUCCESS [20.774s]
[INFO] Flume NG Configuration ............................ SUCCESS [0.261s]
[INFO] Flume NG Core ..................................... SUCCESS [1:45.541s]
[INFO] Flume NG Sinks .................................... SUCCESS [0.052s]
[INFO] Flume NG HDFS Sink ................................ SUCCESS [34.842s]
[INFO] Flume NG IRC Sink ................................. SUCCESS [0.220s]
[INFO] Flume NG Channels ................................. SUCCESS [0.204s]
[INFO] Flume NG JDBC channel ............................. SUCCESS [41.959s]
[INFO] Flume NG Node ..................................... SUCCESS [18.442s]
[INFO] Flume NG file-based channel ....................... SUCCESS [0.756s]
[INFO] Flume NG file backed Memory channel ............... SUCCESS [22.213s]
[INFO] Flume legacy Sources .............................. SUCCESS [0.045s]
[INFO] Flume legacy Avro source .......................... SUCCESS [1.678s]
[INFO] Flume legacy Thrift Source ........................ SUCCESS [0.716s]
[INFO] Flume NG Clients .................................. SUCCESS [0.039s]


Thanks,

Alexander


                
> Attempt to build Flume v1.1.0 on Windows 7 x64 fails
> ----------------------------------------------------
>
>                 Key: FLUME-1174
>                 URL: https://issues.apache.org/jira/browse/FLUME-1174
>             Project: Flume
>          Issue Type: Bug
>    Affects Versions: v1.1.0
>         Environment: Windows 7 - 64 Bit - jdk1.7u4 - mvn 3.0.4
>            Reporter: Jeff Lord
>            Assignee: Alexander Lorenz-Alten
>
> It looks as if the src is expecting to be built on Linux.
> Attempting to build on Windows 7 fails with the below error that references a 
> missing /etc/passwd file.
> Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.156 sec
> Running org.apache.flume.TestCounterGroup
> Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.109 sec
> Results :
> Failed tests:   testRestart(org.apache.flume.source.TestExecSource)
> Tests in error:
>   test(org.apache.flume.serialization.TestBodyTextEventSerializer): Unable to 
> de
> lete file: src\test\resources\events.txt
>   testProcess(org.apache.flume.source.TestExecSource): \etc\passwd (The 
> system c
> annot find the path specified)
> Tests run: 114, Failures: 1, Errors: 2, Skipped: 2

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to