----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4939/#review7719 -----------------------------------------------------------
Ship it! +1 Please rebase the patch and attach it to the Jira. - Arvind On 2012-04-30 21:33:09, Hari Shreedharan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4939/ > ----------------------------------------------------------- > > (Updated 2012-04-30 21:33:09) > > > Review request for Flume. > > > Summary > ------- > > Refactored the NodeConfigurationAware interface, into 2 functions for > starting and stopping components. > > > This addresses bug FLUME-1164. > https://issues.apache.org/jira/browse/FLUME-1164 > > > Diffs > ----- > > > flume-ng-node/src/main/java/org/apache/flume/conf/properties/PropertiesFileConfigurationProvider.java > c6ae2f5 > > flume-ng-node/src/main/java/org/apache/flume/node/nodemanager/DefaultLogicalNodeManager.java > 07c3d0b > > flume-ng-node/src/main/java/org/apache/flume/node/nodemanager/NodeConfigurationAware.java > 47249e9 > > Diff: https://reviews.apache.org/r/4939/diff > > > Testing > ------- > > > Thanks, > > Hari > >
