----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4514/#review7724 -----------------------------------------------------------
Looks good to me. It doesn't seem to patch correctly against the trunk, so if you could rebase it, that would help. While not relevant to this issue, the configuration for this should really be documented, we can't expect end users to trawl the code to figure it out If you can fix these niggles when you rebase it, shoud be good to go flume-ng-configuration/src/main/java/org/apache/flume/conf/channel/MultiplexingChannelSelectorConfiguration.java <https://reviews.apache.org/r/4514/#comment17020> Changing the name immutableMap to something more descriptive would help legibility flume-ng-core/src/main/java/org/apache/flume/channel/MultiplexingChannelSelector.java <https://reviews.apache.org/r/4514/#comment17018> weird indentation(this should be ending the function... looks like refactoring tools used the wrong closing bracket - Juhani On 2012-04-24 04:22:25, Hari Shreedharan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4514/ > ----------------------------------------------------------- > > (Updated 2012-04-24 04:22:25) > > > Review request for Flume. > > > Summary > ------- > > Channel selector config > > > This addresses bug FLUME-1064. > https://issues.apache.org/jira/browse/FLUME-1064 > > > Diffs > ----- > > > flume-ng-configuration/src/main/java/org/apache/flume/conf/channel/MultiplexingChannelSelectorConfiguration.java > PRE-CREATION > > flume-ng-core/src/main/java/org/apache/flume/channel/MultiplexingChannelSelector.java > 83928b7 > > flume-ng-core/src/main/java/org/apache/flume/channel/ReplicatingChannelSelector.java > 8f22746 > > Diff: https://reviews.apache.org/r/4514/diff > > > Testing > ------- > > > Thanks, > > Hari > >
