[
https://issues.apache.org/jira/browse/FLUME-1064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13271220#comment-13271220
]
[email protected] commented on FLUME-1064:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4514/#review7724
-----------------------------------------------------------
Looks good to me.
It doesn't seem to patch correctly against the trunk, so if you could rebase
it, that would help.
While not relevant to this issue, the configuration for this should really be
documented, we can't expect end users to trawl the code to figure it out
If you can fix these niggles when you rebase it, shoud be good to go
flume-ng-configuration/src/main/java/org/apache/flume/conf/channel/MultiplexingChannelSelectorConfiguration.java
<https://reviews.apache.org/r/4514/#comment17020>
Changing the name immutableMap to something more descriptive would help
legibility
flume-ng-core/src/main/java/org/apache/flume/channel/MultiplexingChannelSelector.java
<https://reviews.apache.org/r/4514/#comment17018>
weird indentation(this should be ending the function... looks like
refactoring tools used the wrong closing bracket
- Juhani
On 2012-04-24 04:22:25, Hari Shreedharan wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4514/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-04-24 04:22:25)
bq.
bq.
bq. Review request for Flume.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Channel selector config
bq.
bq.
bq. This addresses bug FLUME-1064.
bq. https://issues.apache.org/jira/browse/FLUME-1064
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
flume-ng-configuration/src/main/java/org/apache/flume/conf/channel/MultiplexingChannelSelectorConfiguration.java
PRE-CREATION
bq.
flume-ng-core/src/main/java/org/apache/flume/channel/MultiplexingChannelSelector.java
83928b7
bq.
flume-ng-core/src/main/java/org/apache/flume/channel/ReplicatingChannelSelector.java
8f22746
bq.
bq. Diff: https://reviews.apache.org/r/4514/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Hari
bq.
bq.
> Channel selector configuration
> ------------------------------
>
> Key: FLUME-1064
> URL: https://issues.apache.org/jira/browse/FLUME-1064
> Project: Flume
> Issue Type: Sub-task
> Reporter: Hari Shreedharan
> Assignee: Hari Shreedharan
> Fix For: v1.2.0
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
