[
https://issues.apache.org/jira/browse/FLUME-1164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13271718#comment-13271718
]
[email protected] commented on FLUME-1164:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4939/
-----------------------------------------------------------
(Updated 2012-05-09 19:26:00.814385)
Review request for Flume.
Changes
-------
Rebased. updated a test class to support the new interface.
Summary
-------
Refactored the NodeConfigurationAware interface, into 2 functions for starting
and stopping components.
This addresses bug FLUME-1164.
https://issues.apache.org/jira/browse/FLUME-1164
Diffs (updated)
-----
flume-ng-node/src/main/java/org/apache/flume/conf/properties/PropertiesFileConfigurationProvider.java
878feda
flume-ng-node/src/main/java/org/apache/flume/node/nodemanager/DefaultLogicalNodeManager.java
292ebcd
flume-ng-node/src/main/java/org/apache/flume/node/nodemanager/NodeConfigurationAware.java
47249e9
flume-ng-node/src/test/java/org/apache/flume/conf/properties/TestPropertiesFileConfigurationProvider.java
48659c4
Diff: https://reviews.apache.org/r/4939/diff
Testing
-------
Thanks,
Hari
> Reconsider whether configure() should be called on the same component object
> after a reconfig event
> ---------------------------------------------------------------------------------------------------
>
> Key: FLUME-1164
> URL: https://issues.apache.org/jira/browse/FLUME-1164
> Project: Flume
> Issue Type: Bug
> Components: Configuration
> Affects Versions: v1.1.0
> Reporter: Will McQueen
> Assignee: Hari Shreedharan
> Fix For: v1.2.0
>
>
> After a reconfiguration event (config file is modified), the configure()
> method is called on the same component object (unless its name or type has
> changed in the config file). For example, changing the config file to add a
> new property or changing an existing property for source component instance
> r1 will cause the object's configure() method to be called again.
> We should consider whether this should be expected behavior, or if a reconfig
> event should result in instantiating new objects for all components specified
> in the config file.
> For reference, please see:
> FLUME-932
> FLUME-933
> FLUME-1036
> FLUME-1162
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
