> On 2012-05-14 10:20:20, Juhani Connolly wrote: > > flume-ng-sinks/flume-ng-hbase-sink/src/main/java/org/apache/flume/sink/hbase/HBaseSink.java, > > line 152 > > <https://reviews.apache.org/r/5073/diff/4/?file=108798#file108798line152> > > > > I'm not entirely convinced by the need to set all puts to the same > > column family, when everything else is pretty customizable. Saving on > > transferring the columnFamily data everytime? Perhaps make it overridable > > with an optional header.
I am going to file a bug for this, and for adding unit tests. > On 2012-05-14 10:20:20, Juhani Connolly wrote: > > flume-ng-sinks/flume-ng-hbase-sink/src/main/java/org/apache/flume/sink/hbase/HBaseSink.java, > > line 175 > > <https://reviews.apache.org/r/5073/diff/4/?file=108798#file108798line175> > > > > Looks to me like if there is no configuration for this in the context, > > you'll be passing a null here... Which will then result in a NPE? fixed. > On 2012-05-14 10:20:20, Juhani Connolly wrote: > > flume-ng-sinks/flume-ng-hbase-sink/src/main/java/org/apache/flume/sink/hbase/HBaseSink.java, > > line 203 > > <https://reviews.apache.org/r/5073/diff/4/?file=108798#file108798line203> > > > > I think you should be calling putEventsAndCommit here? Otherwise it > > looks to me like you're losing anything that was take'd between the last > > PEAC and reaching the batchsize Fixed. - Hari ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5073/#review7835 ----------------------------------------------------------- On 2012-05-14 18:31:15, Hari Shreedharan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5073/ > ----------------------------------------------------------- > > (Updated 2012-05-14 18:31:15) > > > Review request for Flume. > > > Summary > ------- > > Hbase sink. > > > This addresses bug FLUME-1183. > https://issues.apache.org/jira/browse/FLUME-1183 > > > Diffs > ----- > > bin/flume-ng 0108997 > flume-ng-dist/pom.xml 5bdcfe7 > flume-ng-sinks/flume-ng-hbase-sink/pom.xml PRE-CREATION > > flume-ng-sinks/flume-ng-hbase-sink/src/main/java/org/apache/flume/sink/hbase/HBaseSink.java > PRE-CREATION > > flume-ng-sinks/flume-ng-hbase-sink/src/main/java/org/apache/flume/sink/hbase/HbaseEventSerializer.java > PRE-CREATION > > flume-ng-sinks/flume-ng-hbase-sink/src/main/java/org/apache/flume/sink/hbase/SimpleHbaseEventSerializer.java > PRE-CREATION > > flume-ng-sinks/flume-ng-hbase-sink/src/main/java/org/apache/flume/sink/hbase/SimpleRowKeyGenerator.java > PRE-CREATION > > flume-ng-sinks/flume-ng-hbase-sink/src/test/java/org/apache/flume/sink/hbase/TestHBaseSink.java > PRE-CREATION > flume-ng-sinks/pom.xml acb3087 > pom.xml 8c11a2d > > Diff: https://reviews.apache.org/r/5073/diff > > > Testing > ------- > > Unit tests added > > > Thanks, > > Hari > >
