----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5161/#review7973 -----------------------------------------------------------
Thank you for the patch! Looks good in general, just two issues below. /trunk/flume-ng-core/src/main/java/org/apache/flume/sink/AbstractSinkSelector.java <https://reviews.apache.org/r/5161/#comment17321> remove codegen /trunk/flume-ng-core/src/test/java/org/apache/flume/sink/TestLoadBalancingSinkProcessor.java <https://reviews.apache.org/r/5161/#comment17320> We want to be checking s1..s0 as opposed to s1 and s3? - Brock On 2012-05-18 08:02:10, Arvind Prabhakar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5161/ > ----------------------------------------------------------- > > (Updated 2012-05-18 08:02:10) > > > Review request for Flume and Juhani Connolly. > > > Summary > ------- > > Added a load-balancing sink processor that uses default round-robin policy to > select sinks from the group. In case of failure, it skips the sink and goes > to the next. Can be configured to use random distribution of load instead of > default round-robin semantics. > > Also, this processor accepts implementations of sink selectors which can be > used to route the load into various sinks. > > > This addresses bug FLUME-1198. > https://issues.apache.org/jira/browse/FLUME-1198 > > > Diffs > ----- > > > /trunk/flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/SinkProcessorType.java > 1339941 > > /trunk/flume-ng-core/src/main/java/org/apache/flume/sink/AbstractSinkProcessor.java > PRE-CREATION > > /trunk/flume-ng-core/src/main/java/org/apache/flume/sink/AbstractSinkSelector.java > PRE-CREATION > > /trunk/flume-ng-core/src/main/java/org/apache/flume/sink/FailoverSinkProcessor.java > 1339941 > > /trunk/flume-ng-core/src/main/java/org/apache/flume/sink/LoadBalancingSinkProcessor.java > PRE-CREATION > > /trunk/flume-ng-core/src/test/java/org/apache/flume/sink/FixedOrderSelector.java > PRE-CREATION > > /trunk/flume-ng-core/src/test/java/org/apache/flume/sink/SinkProcessorFactoryTest.java > 1339941 > > /trunk/flume-ng-core/src/test/java/org/apache/flume/sink/TestLoadBalancingSinkProcessor.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/5161/diff > > > Testing > ------- > > Introduced new tests and ran all existing tests. > > > Thanks, > > Arvind > >
