----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5163/#review7984 -----------------------------------------------------------
Ship it! +1 Thanks for the patch Mike, changes look good! - Arvind On 2012-05-18 21:51:36, Mike Percy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5163/ > ----------------------------------------------------------- > > (Updated 2012-05-18 21:51:36) > > > Review request for Flume. > > > Summary > ------- > > Support for acting as multiple proxy users from a single, authenticated > principal. > > > This addresses bug FLUME-1196. > https://issues.apache.org/jira/browse/FLUME-1196 > > > Diffs > ----- > > flume-ng-sinks/flume-hdfs-sink/pom.xml 3277a00 > > flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/HDFSEventSink.java > 8ce2bac > > flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/HDFSFormatterFactory.java > d7963b1 > > flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/KerberosUser.java > PRE-CREATION > > flume-ng-sinks/flume-hdfs-sink/src/test/java/org/apache/flume/sink/hdfs/TestHDFSEventSinkOnMiniCluster.java > PRE-CREATION > flume-ng-sinks/flume-hdfs-sink/src/test/resources/log4j.properties 361158d > pom.xml 7a97c34 > > Diff: https://reviews.apache.org/r/5163/diff > > > Testing > ------- > > Added unit test and small framework for testing using MiniDFSCluster. > Existing tests pass. Also, a non-trivial amount of manual testing (no > Kerberos, Kerb only, Kerb+proxy, combination of Kerb & Kerb+proxy in same > agent) > > > Thanks, > > Mike > >
