----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5175/#review8013 -----------------------------------------------------------
Ship it! +1 Changes look good. Will commit if tests pass. - Arvind On 2012-05-21 10:24:48, Mike Percy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5175/ > ----------------------------------------------------------- > > (Updated 2012-05-21 10:24:48) > > > Review request for Flume. > > > Summary > ------- > > BucketWriter refactoring: append() does all the work of open/close/roll. > open() is a private method that takes no arguments. No abort() call. Only one > constructor. > Far fewer entry points and code paths. I believe I've closed all or many of > the race conditions and clarified the API responsibilities/semantics. > > > This addresses bug FLUME-1219. > https://issues.apache.org/jira/browse/FLUME-1219 > > > Diffs > ----- > > > flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/BucketWriter.java > 91cb822 > > flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/HDFSEventSink.java > d272f74 > > flume-ng-sinks/flume-hdfs-sink/src/test/java/org/apache/flume/sink/hdfs/TestBucketWriter.java > 397138b > > flume-ng-sinks/flume-hdfs-sink/src/test/java/org/apache/flume/sink/hdfs/TestHDFSEventSink.java > 0f78f37 > > Diff: https://reviews.apache.org/r/5175/diff > > > Testing > ------- > > Looks good under load. Unit tests pass. > > > Thanks, > > Mike > >
