> On 2012-05-29 17:04:02, Hari Shreedharan wrote: > > lgtm!
Please attach the patch to the jira. - Hari ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5228/#review8169 ----------------------------------------------------------- On 2012-05-25 21:40:21, Mike Percy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5228/ > ----------------------------------------------------------- > > (Updated 2012-05-25 21:40:21) > > > Review request for Flume. > > > Summary > ------- > > BucketWriter should not be using System.nanoTime() as a start time for file > suffix incrementation, because it's not guaranteed to be monotonically > increasing across system and process restarts. > > Also made the variable non-static. > > > This addresses bug FLUME-1229. > https://issues.apache.org/jira/browse/FLUME-1229 > > > Diffs > ----- > > > flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/BucketWriter.java > bbb398f > > Diff: https://reviews.apache.org/r/5228/diff > > > Testing > ------- > > > Thanks, > > Mike > >
