----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5046/#review8176 -----------------------------------------------------------
flume-ng-core/src/test/java/org/apache/flume/source/TestExecSource.java <https://reviews.apache.org/r/5046/#comment17677> Does cat exist on Windows? Is there any other command that can be used, perhaps with an OS specific check? like this: if(os == windows) { command = <windows_command> } else { command = <posix_command> } - Hari On 2012-05-06 13:21:54, Alexander Alten-Lorenz wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5046/ > ----------------------------------------------------------- > > (Updated 2012-05-06 13:21:54) > > > Review request for Flume. > > > Summary > ------- > > FLUME-1174 describes an error when Flume is built on Windows machines. The > error occurs through hardcoded test cases which assume a /etc/passwd file and > a hardcoded /tmp path. As revealed in the Jira that could be an security > issue. On top it makes it impossible to build Flume on non standard Linux > operating systems (including Busy Box, grml, Windows etc). > > > This addresses bug FLUME-1174. > https://issues.apache.org/jira/browse/FLUME-1174 > > > Diffs > ----- > > flume-ng-core/src/test/java/org/apache/flume/source/TestExecSource.java > 615f2a3 > > Diff: https://reviews.apache.org/r/5046/diff > > > Testing > ------- > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Apache Flume ...................................... SUCCESS [1.575s] > [INFO] Flume NG SDK ...................................... SUCCESS [20.774s] > [INFO] Flume NG Configuration ............................ SUCCESS [0.261s] > [INFO] Flume NG Core ..................................... SUCCESS [1:45.541s] > [INFO] Flume NG Sinks .................................... SUCCESS [0.052s] > [INFO] Flume NG HDFS Sink ................................ SUCCESS [34.842s] > [INFO] Flume NG IRC Sink ................................. SUCCESS [0.220s] > [INFO] Flume NG Channels ................................. SUCCESS [0.204s] > [INFO] Flume NG JDBC channel ............................. SUCCESS [41.959s] > [INFO] Flume NG Node ..................................... SUCCESS [18.442s] > [INFO] Flume NG file-based channel ....................... SUCCESS [0.756s] > [INFO] Flume NG file backed Memory channel ............... SUCCESS [22.213s] > [INFO] Flume legacy Sources .............................. SUCCESS [0.045s] > [INFO] Flume legacy Avro source .......................... SUCCESS [1.678s] > [INFO] Flume legacy Thrift Source ........................ SUCCESS [0.716s] > [INFO] Flume NG Clients .................................. SUCCESS [0.039s] > > > Thanks, > > Alexander > >
