----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5314/#review8261 -----------------------------------------------------------
Ship it! +1 - Arvind On 2012-05-31 06:31:43, Mike Percy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5314/ > ----------------------------------------------------------- > > (Updated 2012-05-31 06:31:43) > > > Review request for Flume. > > > Summary > ------- > > hdfs.fileType = CompressedStream has a bug in which it calls finish() on the > output stream when it should be calling flush(). > > > This addresses bug FLUME-1245. > https://issues.apache.org/jira/browse/FLUME-1245 > > > Diffs > ----- > > > flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/HDFSCompressedDataStream.java > 98188c8 > > flume-ng-sinks/flume-hdfs-sink/src/test/java/org/apache/flume/sink/hdfs/TestHDFSEventSinkOnMiniCluster.java > 1ed55d6 > > Diff: https://reviews.apache.org/r/5314/diff > > > Testing > ------- > > Added unit test which fails on existing code but passes after patch is > applied. Also, some manual testing. > > > Thanks, > > Mike > >
