----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5325/ -----------------------------------------------------------
Review request for Flume and Hari Shreedharan. Summary ------- This is the patch I posted on FLUME-1230 which includes refactoring of configuration. The patch includes some tests. Diffs ----- /trunk/flume-ng-configuration/src/main/java/org/apache/flume/conf/AgentConfiguration.java PRE-CREATION /trunk/flume-ng-configuration/src/main/java/org/apache/flume/conf/ComponentConfiguration.java 1342958 /trunk/flume-ng-configuration/src/main/java/org/apache/flume/conf/ComponentConfigurationDelegate.java PRE-CREATION /trunk/flume-ng-configuration/src/main/java/org/apache/flume/conf/ComponentConfigurationFactory.java 1342958 /trunk/flume-ng-configuration/src/main/java/org/apache/flume/conf/ComponentType.java PRE-CREATION /trunk/flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfiguration.java 1342958 /trunk/flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfigurationErrorType.java 1342958 /trunk/flume-ng-configuration/src/main/java/org/apache/flume/conf/channel/ChannelConfiguration.java 1342958 /trunk/flume-ng-configuration/src/main/java/org/apache/flume/conf/channel/ChannelSelectorConfiguration.java 1342958 /trunk/flume-ng-configuration/src/main/java/org/apache/flume/conf/channel/ChannelSelectorType.java 1342958 /trunk/flume-ng-configuration/src/main/java/org/apache/flume/conf/channel/ChannelType.java 1342958 /trunk/flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/SinkConfiguration.java 1342958 /trunk/flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/SinkGroupConfiguration.java 1342958 /trunk/flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/SinkGroupProcessorConfiguration.java PRE-CREATION /trunk/flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/SinkGroupProcessorType.java PRE-CREATION /trunk/flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/SinkProcessorConfiguration.java 1342958 /trunk/flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/SinkProcessorType.java 1342958 /trunk/flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/SinkType.java 1342958 /trunk/flume-ng-configuration/src/main/java/org/apache/flume/conf/source/SourceConfiguration.java 1342958 /trunk/flume-ng-configuration/src/main/java/org/apache/flume/conf/source/SourceType.java 1342958 /trunk/flume-ng-configuration/src/test/java/org/apache/flume/conf/TestConfiguration.java PRE-CREATION /trunk/flume-ng-configuration/src/test/resources/no-active-sink-conf.properties PRE-CREATION /trunk/flume-ng-configuration/src/test/resources/some-active-sink-conf.properties PRE-CREATION /trunk/flume-ng-core/src/main/java/org/apache/flume/conf/Configurables.java 1342958 /trunk/flume-ng-core/src/main/java/org/apache/flume/sink/SinkGroup.java 1342958 /trunk/flume-ng-core/src/main/java/org/apache/flume/sink/SinkProcessorFactory.java 1342958 /trunk/flume-ng-node/src/main/java/org/apache/flume/conf/properties/PropertiesFileConfigurationProvider.java 1342958 Diff: https://reviews.apache.org/r/5325/diff Testing ------- All tests run fine and basic manual testing was fine as well. Thanks, Arvind
